diff options
| author | Zack Weinberg <zackw@panix.com> | 2018-06-01 12:53:59 -0400 |
|---|---|---|
| committer | Zack Weinberg <zackw@panix.com> | 2018-06-12 10:02:27 -0400 |
| commit | 2ba9f2eb978b27ddfa39cd769b73136d0ac4c4ae (patch) | |
| tree | fabc08af34d8fbe8227e072ade54be411c6a4123 /elf/dl-fptr.c | |
| parent | 329ea513b451ae8322aa7a24ed84da13992af2dd (diff) | |
| download | glibc-zack/elf-builtin-expect-conversion.tar glibc-zack/elf-builtin-expect-conversion.tar.gz glibc-zack/elf-builtin-expect-conversion.tar.bz2 glibc-zack/elf-builtin-expect-conversion.zip | |
Convert __builtin_expect to __glibc_(un)likely throughout elf/.zack/elf-builtin-expect-conversion
In the previous patch I didn't change a use of __builtin_expect to
__glibc_(un)likely that happened to be right next to the code I was
actually working on; Andreas asked why not, and I said that there were
a bunch more uses of __builtin_expect in that file and I would convert
them all in a separate patch. This is that patch, converting all of
elf/.
I would appreciate someone checking over this patch very carefully
indeed. In a whole bunch of places, __builtin_expect was used in a
way that did not map mechanically to the newer convention. The test
suite caught one mistake; I'm not confident I didn't make any more.
Writing this patch gave me a deeper appreciation for why we _want_ to
switch to __glibc_(un)likely, but also for how difficult it can be. I
now think that people should _not_ be asked to change existing uses of
__builtin_expect in a patch whose purpose is something else.
* elf/dl-addr.c, elf/dl-cache.c, elf/dl-close.c, elf/dl-deps.c
* elf/dl-environ.c, elf/dl-error-skeleton.c, elf/dl-fini.c
* elf/dl-fptr.c, elf/dl-init.c, elf/dl-libc.c, elf/dl-minimal.c
* elf/dl-open.c, elf/dl-reloc.c, elf/dl-runtime.c
* elf/dl-sysdep.c, elf/dl-tls.c, elf/dl-version.c, elf/ldconfig.c
* elf/rtld.c: Replace __builtin_expect with __glibc_likely or
__glibc_unlikely, as appropriate, throughout.
Diffstat (limited to 'elf/dl-fptr.c')
| -rw-r--r-- | elf/dl-fptr.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/elf/dl-fptr.c b/elf/dl-fptr.c index 027c5029eb..a7701410f9 100644 --- a/elf/dl-fptr.c +++ b/elf/dl-fptr.c @@ -227,8 +227,8 @@ _dl_make_fptr (struct link_map *map, const ElfW(Sym) *sym, ElfW(Addr) fdesc = make_fdesc (ip, map->l_info[DT_PLTGOT]->d_un.d_ptr); - if (__builtin_expect (COMPARE_AND_SWAP (&ftab[symidx], (ElfW(Addr)) NULL, - fdesc), 1)) + if (__glibc_likely (COMPARE_AND_SWAP (&ftab[symidx], (ElfW(Addr)) NULL, + fdesc) == 1)) { /* Noone has updated the entry and the new function descriptor has been installed. */ |