diff options
author | Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com> | 2017-02-17 09:07:57 -0200 |
---|---|---|
committer | Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com> | 2017-02-17 09:07:57 -0200 |
commit | 51b34a9c47e4228873788ad66699c328e27a3295 (patch) | |
tree | dae7359c968c1a37cf775e42b93e9d93500b456d | |
parent | f0166c1643038e0ca42d300ddae36c00f400f4cf (diff) | |
download | glibc-51b34a9c47e4228873788ad66699c328e27a3295.tar glibc-51b34a9c47e4228873788ad66699c328e27a3295.tar.gz glibc-51b34a9c47e4228873788ad66699c328e27a3295.tar.bz2 glibc-51b34a9c47e4228873788ad66699c328e27a3295.zip |
Fix lgamma*, log10* and log2* results [BZ #21171]
lgamma(-x) should return +Inf and raise divide-by-zero.
log10(+-0) and log2(+-0) should return -Inf and raise divide-by-zero.
Tested on powerpc, powerpc64, powerpc64le and x86_64.
[BZ #21171]
* sysdeps/ieee754/dbl-64/e_lgamma_r.c (__ieee754_lgamma_r): Return
+Inf and raise divide-by-zero when x is negative.
* sysdeps/ieee754/flt-32/e_lgammaf_r.c (__ieee754_lgammaf_r): Likewise.
* sysdeps/ieee754/ldbl-128/e_lgammal_r.c (__ieee754_lgammal_r): Likewise.
* sysdeps/ieee754/dbl-64/e_log10.c (__ieee754_log10): Return
-Inf and raise divide-by-zero when x = +-0.
* sysdeps/ieee754/dbl-64/e_log2.c (__ieee754_log2): Likewise.
* sysdeps/ieee754/flt-32/e_log10f.c (__ieee754_log10f): Likewise.
* sysdeps/ieee754/flt-32/e_log2f.c (__ieee754_log2f): Likewise.
* sysdeps/ieee754/ldbl-128/e_log10l.c (__ieee754_log10l): Likewise.
* sysdeps/ieee754/ldbl-128/e_log2l.c (__ieee754_log2l): Likewise.
* sysdeps/ieee754/ldbl-128ibm/e_log10l.c (__ieee754_log10l): Likewise.
* sysdeps/ieee754/ldbl-128ibm/e_log2l.c (__ieee754_log2l): Likewise.
-rw-r--r-- | ChangeLog | 17 | ||||
-rw-r--r-- | sysdeps/ieee754/dbl-64/e_lgamma_r.c | 2 | ||||
-rw-r--r-- | sysdeps/ieee754/dbl-64/e_log10.c | 2 | ||||
-rw-r--r-- | sysdeps/ieee754/dbl-64/e_log2.c | 2 | ||||
-rw-r--r-- | sysdeps/ieee754/flt-32/e_lgammaf_r.c | 2 | ||||
-rw-r--r-- | sysdeps/ieee754/flt-32/e_log10f.c | 2 | ||||
-rw-r--r-- | sysdeps/ieee754/flt-32/e_log2f.c | 2 | ||||
-rw-r--r-- | sysdeps/ieee754/ldbl-128/e_lgammal_r.c | 2 | ||||
-rw-r--r-- | sysdeps/ieee754/ldbl-128/e_log10l.c | 2 | ||||
-rw-r--r-- | sysdeps/ieee754/ldbl-128/e_log2l.c | 2 | ||||
-rw-r--r-- | sysdeps/ieee754/ldbl-128ibm/e_log10l.c | 2 | ||||
-rw-r--r-- | sysdeps/ieee754/ldbl-128ibm/e_log2l.c | 2 |
12 files changed, 28 insertions, 11 deletions
@@ -1,3 +1,20 @@ +2017-02-17 Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com> + + [BZ #21171] + * sysdeps/ieee754/dbl-64/e_lgamma_r.c (__ieee754_lgamma_r): Return + +Inf and raise divide-by-zero when x is negative. + * sysdeps/ieee754/flt-32/e_lgammaf_r.c (__ieee754_lgammaf_r): Likewise. + * sysdeps/ieee754/ldbl-128/e_lgammal_r.c (__ieee754_lgammal_r): Likewise. + * sysdeps/ieee754/dbl-64/e_log10.c (__ieee754_log10): Return + -Inf and raise divide-by-zero when x = +-0. + * sysdeps/ieee754/dbl-64/e_log2.c (__ieee754_log2): Likewise. + * sysdeps/ieee754/flt-32/e_log10f.c (__ieee754_log10f): Likewise. + * sysdeps/ieee754/flt-32/e_log2f.c (__ieee754_log2f): Likewise. + * sysdeps/ieee754/ldbl-128/e_log10l.c (__ieee754_log10l): Likewise. + * sysdeps/ieee754/ldbl-128/e_log2l.c (__ieee754_log2l): Likewise. + * sysdeps/ieee754/ldbl-128ibm/e_log10l.c (__ieee754_log10l): Likewise. + * sysdeps/ieee754/ldbl-128ibm/e_log2l.c (__ieee754_log2l): Likewise. + 2017-02-16 Zack Weinberg <zackw@panix.com> * scripts/build-many-glibcs.py (bot_build_mail): If the diff --git a/sysdeps/ieee754/dbl-64/e_lgamma_r.c b/sysdeps/ieee754/dbl-64/e_lgamma_r.c index 15154c0f43..c337679f7c 100644 --- a/sysdeps/ieee754/dbl-64/e_lgamma_r.c +++ b/sysdeps/ieee754/dbl-64/e_lgamma_r.c @@ -225,7 +225,7 @@ __ieee754_lgamma_r(double x, int *signgamp) if(hx<0) { if(__builtin_expect(ix>=0x43300000, 0)) /* |x|>=2**52, must be -integer */ - return x/zero; + return __fabs (x)/zero; if (x < -2.0 && x > -28.0) return __lgamma_neg (x, signgamp); t = sin_pi(x); diff --git a/sysdeps/ieee754/dbl-64/e_log10.c b/sysdeps/ieee754/dbl-64/e_log10.c index df59d9dce4..bf40bca874 100644 --- a/sysdeps/ieee754/dbl-64/e_log10.c +++ b/sysdeps/ieee754/dbl-64/e_log10.c @@ -65,7 +65,7 @@ __ieee754_log10 (double x) if (hx < 0x00100000) { /* x < 2**-1022 */ if (__glibc_unlikely (((hx & 0x7fffffff) | lx) == 0)) - return -two54 / (x - x); /* log(+-0)=-inf */ + return -two54 / __fabs (x); /* log(+-0)=-inf */ if (__glibc_unlikely (hx < 0)) return (x - x) / (x - x); /* log(-#) = NaN */ k -= 54; diff --git a/sysdeps/ieee754/dbl-64/e_log2.c b/sysdeps/ieee754/dbl-64/e_log2.c index bc6a34192a..5af68d8ecc 100644 --- a/sysdeps/ieee754/dbl-64/e_log2.c +++ b/sysdeps/ieee754/dbl-64/e_log2.c @@ -83,7 +83,7 @@ __ieee754_log2 (double x) if (hx < 0x00100000) { /* x < 2**-1022 */ if (__glibc_unlikely (((hx & 0x7fffffff) | lx) == 0)) - return -two54 / (x - x); /* log(+-0)=-inf */ + return -two54 / __fabs (x); /* log(+-0)=-inf */ if (__glibc_unlikely (hx < 0)) return (x - x) / (x - x); /* log(-#) = NaN */ k -= 54; diff --git a/sysdeps/ieee754/flt-32/e_lgammaf_r.c b/sysdeps/ieee754/flt-32/e_lgammaf_r.c index 4d8a66bb39..1bd2122663 100644 --- a/sysdeps/ieee754/flt-32/e_lgammaf_r.c +++ b/sysdeps/ieee754/flt-32/e_lgammaf_r.c @@ -160,7 +160,7 @@ __ieee754_lgammaf_r(float x, int *signgamp) } if(hx<0) { if(ix>=0x4b000000) /* |x|>=2**23, must be -integer */ - return x/zero; + return __fabsf (x)/zero; if (ix > 0x40000000 /* X < 2.0f. */ && ix < 0x41700000 /* X > -15.0f. */) return __lgamma_negf (x, signgamp); diff --git a/sysdeps/ieee754/flt-32/e_log10f.c b/sysdeps/ieee754/flt-32/e_log10f.c index 2cd01b4a50..aa21bbc9c5 100644 --- a/sysdeps/ieee754/flt-32/e_log10f.c +++ b/sysdeps/ieee754/flt-32/e_log10f.c @@ -34,7 +34,7 @@ __ieee754_log10f(float x) k=0; if (hx < 0x00800000) { /* x < 2**-126 */ if (__builtin_expect((hx&0x7fffffff)==0, 0)) - return -two25/(x-x); /* log(+-0)=-inf */ + return -two25/__fabsf (x); /* log(+-0)=-inf */ if (__builtin_expect(hx<0, 0)) return (x-x)/(x-x); /* log(-#) = NaN */ k -= 25; x *= two25; /* subnormal number, scale up x */ diff --git a/sysdeps/ieee754/flt-32/e_log2f.c b/sysdeps/ieee754/flt-32/e_log2f.c index 857d13fb9b..782d901094 100644 --- a/sysdeps/ieee754/flt-32/e_log2f.c +++ b/sysdeps/ieee754/flt-32/e_log2f.c @@ -43,7 +43,7 @@ __ieee754_log2f(float x) k=0; if (ix < 0x00800000) { /* x < 2**-126 */ if (__builtin_expect((ix&0x7fffffff)==0, 0)) - return -two25/(x-x); /* log(+-0)=-inf */ + return -two25/__fabsf (x); /* log(+-0)=-inf */ if (__builtin_expect(ix<0, 0)) return (x-x)/(x-x); /* log(-#) = NaN */ k -= 25; x *= two25; /* subnormal number, scale up x */ diff --git a/sysdeps/ieee754/ldbl-128/e_lgammal_r.c b/sysdeps/ieee754/ldbl-128/e_lgammal_r.c index 6f55b4da6a..bef2601bce 100644 --- a/sysdeps/ieee754/ldbl-128/e_lgammal_r.c +++ b/sysdeps/ieee754/ldbl-128/e_lgammal_r.c @@ -782,7 +782,7 @@ __ieee754_lgammal_r (_Float128 x, int *signgamp) q = -x; p = __floorl (q); if (p == q) - return (one / (p - p)); + return (one / __fabsl (p - p)); _Float128 halfp = p * L(0.5); if (halfp == __floorl (halfp)) *signgamp = -1; diff --git a/sysdeps/ieee754/ldbl-128/e_log10l.c b/sysdeps/ieee754/ldbl-128/e_log10l.c index f73cd34ebb..c992f6e5ee 100644 --- a/sysdeps/ieee754/ldbl-128/e_log10l.c +++ b/sysdeps/ieee754/ldbl-128/e_log10l.c @@ -187,7 +187,7 @@ __ieee754_log10l (_Float128 x) /* Test for domain */ GET_LDOUBLE_WORDS64 (hx, lx, x); if (((hx & 0x7fffffffffffffffLL) | lx) == 0) - return (-1 / (x - x)); + return (-1 / __fabsl (x)); /* log10l(+-0)=-inf */ if (hx < 0) return (x - x) / (x - x); if (hx >= 0x7fff000000000000LL) diff --git a/sysdeps/ieee754/ldbl-128/e_log2l.c b/sysdeps/ieee754/ldbl-128/e_log2l.c index 26a8d7e6fa..cf4a380f16 100644 --- a/sysdeps/ieee754/ldbl-128/e_log2l.c +++ b/sysdeps/ieee754/ldbl-128/e_log2l.c @@ -181,7 +181,7 @@ __ieee754_log2l (_Float128 x) /* Test for domain */ GET_LDOUBLE_WORDS64 (hx, lx, x); if (((hx & 0x7fffffffffffffffLL) | lx) == 0) - return (-1 / (x - x)); + return (-1 / __fabsl (x)); /* log2l(+-0)=-inf */ if (hx < 0) return (x - x) / (x - x); if (hx >= 0x7fff000000000000LL) diff --git a/sysdeps/ieee754/ldbl-128ibm/e_log10l.c b/sysdeps/ieee754/ldbl-128ibm/e_log10l.c index 7477791b77..1fbfa48e13 100644 --- a/sysdeps/ieee754/ldbl-128ibm/e_log10l.c +++ b/sysdeps/ieee754/ldbl-128ibm/e_log10l.c @@ -189,7 +189,7 @@ __ieee754_log10l (long double x) xhi = ldbl_high (x); EXTRACT_WORDS64 (hx, xhi); if ((hx & 0x7fffffffffffffffLL) == 0) - return (-1.0L / (x - x)); + return (-1.0L / __fabsl (x)); /* log10l(+-0)=-inf */ if (hx < 0) return (x - x) / (x - x); if (hx >= 0x7ff0000000000000LL) diff --git a/sysdeps/ieee754/ldbl-128ibm/e_log2l.c b/sysdeps/ieee754/ldbl-128ibm/e_log2l.c index e39eaba72a..c820dacf08 100644 --- a/sysdeps/ieee754/ldbl-128ibm/e_log2l.c +++ b/sysdeps/ieee754/ldbl-128ibm/e_log2l.c @@ -183,7 +183,7 @@ __ieee754_log2l (long double x) xhi = ldbl_high (x); EXTRACT_WORDS64 (hx, xhi); if ((hx & 0x7fffffffffffffffLL) == 0) - return (-1.0L / (x - x)); + return (-1.0L / __fabsl (x)); /* log2l(+-0)=-inf */ if (hx < 0) return (x - x) / (x - x); if (hx >= 0x7ff0000000000000LL) |