diff options
author | Florian Weimer <fweimer@redhat.com> | 2019-12-03 21:11:32 +0100 |
---|---|---|
committer | Florian Weimer <fweimer@redhat.com> | 2019-12-03 21:11:32 +0100 |
commit | 9f917f7b411c307c34eb1bae85d72ffe26167523 (patch) | |
tree | c2717141667df8e757b9a792e9a75ffa164d74c0 | |
parent | f55e312bcd6582b5ff68fdcc1781c7017796dc91 (diff) | |
download | glibc-9f917f7b411c307c34eb1bae85d72ffe26167523.tar glibc-9f917f7b411c307c34eb1bae85d72ffe26167523.tar.gz glibc-9f917f7b411c307c34eb1bae85d72ffe26167523.tar.bz2 glibc-9f917f7b411c307c34eb1bae85d72ffe26167523.zip |
x86: Assume --enable-cet if GCC defaults to CET [BZ #25225]
This links in CET support if GCC defaults to CET. Otherwise, __CET__
is defined, yet CET functionality is not compiled and linked into the
dynamic loader, resulting in a linker failure due to undefined
references to _dl_cet_check and _dl_open_check.
(cherry picked from commit 9fb8139079ef0bb1aa33a4ae418cbb113b9b9da7)
-rw-r--r-- | NEWS | 1 | ||||
-rwxr-xr-x | configure | 23 | ||||
-rw-r--r-- | configure.ac | 9 |
3 files changed, 31 insertions, 2 deletions
@@ -71,6 +71,7 @@ The following bugs are resolved with this release: [24744] io: Remove the copy_file_range emulation. [25203] libio: Disable vtable validation for pre-2.1 interposed handles [25204] Ignore LD_PREFER_MAP_32BIT_EXEC for SUID programs + [25225] ld.so fails to link on x86 if GCC defaults to -fcf-protection Security related changes: @@ -3762,11 +3762,32 @@ else fi +cat confdefs.h - <<_ACEOF >conftest.$ac_ext +/* end confdefs.h. */ + +int +main () +{ + +#ifndef __CET__ +#error no CET compiler support +#endif + ; + return 0; +} +_ACEOF +if ac_fn_c_try_compile "$LINENO"; then : + libc_cv_compiler_default_cet=yes +else + libc_cv_compiler_default_cet=no +fi +rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext + # Check whether --enable-cet was given. if test "${enable_cet+set}" = set; then : enableval=$enable_cet; enable_cet=$enableval else - enable_cet=no + enable_cet=$libc_cv_compiler_default_cet fi diff --git a/configure.ac b/configure.ac index 014e09a5d5..139554b94a 100644 --- a/configure.ac +++ b/configure.ac @@ -464,11 +464,18 @@ AC_ARG_ENABLE([mathvec], [build_mathvec=$enableval], [build_mathvec=notset]) +AC_TRY_COMPILE([], [ +#ifndef __CET__ +# error no CET compiler support +#endif], + [libc_cv_compiler_default_cet=yes], + [libc_cv_compiler_default_cet=no]) + AC_ARG_ENABLE([cet], AC_HELP_STRING([--enable-cet], [enable Intel Control-flow Enforcement Technology (CET), x86 only]), [enable_cet=$enableval], - [enable_cet=no]) + [enable_cet=$libc_cv_compiler_default_cet]) # We keep the original values in `$config_*' and never modify them, so we # can write them unchanged into config.make. Everything else uses |