aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Weimer <fweimer@redhat.com>2018-01-11 13:13:28 +0100
committerFlorian Weimer <fweimer@redhat.com>2018-01-16 09:27:28 +0100
commitabf2e34ee6a9cf1b7e5afddd13971754e5c5fa82 (patch)
treeb784bd435c13b9f17ef2a7a05ea9523a5536ebba
parent8343b9da62a81c6bbdf997f48778793553142f47 (diff)
downloadglibc-abf2e34ee6a9cf1b7e5afddd13971754e5c5fa82.tar
glibc-abf2e34ee6a9cf1b7e5afddd13971754e5c5fa82.tar.gz
glibc-abf2e34ee6a9cf1b7e5afddd13971754e5c5fa82.tar.bz2
glibc-abf2e34ee6a9cf1b7e5afddd13971754e5c5fa82.zip
csu: Update __libgcc_s_init comment
Reviewed-by: Carlos O'Donell <carlos@redhat.com> (cherry picked from commit 08c6e95234c60a5c2f37532d1111acf084f39345)
-rw-r--r--ChangeLog5
-rw-r--r--sysdeps/gnu/unwind-resume.c8
2 files changed, 11 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index a1028fcdff..6178a89fa6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-01-11 Florian Weimer <fweimer@redhat.com>
+
+ * sysdeps/gnu/unwind-resume.c (__libgcc_s_init): Update comment
+ and error message.
+
2018-01-16 Florian Weimer <fweimer@redhat.com>
* nptl/Makefile (CFLAGS-tst-minstack-throw.o): Compile in C++11
diff --git a/sysdeps/gnu/unwind-resume.c b/sysdeps/gnu/unwind-resume.c
index 1ea833ba9b..ecb4ce2067 100644
--- a/sysdeps/gnu/unwind-resume.c
+++ b/sysdeps/gnu/unwind-resume.c
@@ -35,13 +35,17 @@ __libgcc_s_init (void)
void *resume, *personality;
void *handle;
- handle = __libc_dlopen (LIBGCC_S_SO);
+ /* Use RTLD_NOW here for consistency with pthread_cancel_init.
+ RTLD_NOW will rarely make a difference here because unwinding is
+ already in progress, so libgcc_s.so has already been loaded if
+ its unwinder is used. */
+ handle = __libc_dlopen_mode (LIBGCC_S_SO, RTLD_NOW | __RTLD_DLOPEN);
if (handle == NULL
|| (resume = __libc_dlsym (handle, "_Unwind_Resume")) == NULL
|| (personality = __libc_dlsym (handle, "__gcc_personality_v0")) == NULL)
__libc_fatal (LIBGCC_S_SO
- " must be installed for pthread_cancel to work\n");
+ " must be installed for unwinding to work\n");
#ifdef PTR_MANGLE
PTR_MANGLE (resume);