diff options
| author | Will Newton <will.newton@linaro.org> | 2014-04-04 09:56:42 +0100 |
|---|---|---|
| committer | Will Newton <will.newton@linaro.org> | 2014-06-23 14:13:30 +0100 |
| commit | d6d062255489343810ad1e01d05f70acd9cd1918 (patch) | |
| tree | 453477b6f66dc495e8729ca54f21ee751ce6acac | |
| parent | f393b4aaedd32238738708f6b180fe91a0ae85f8 (diff) | |
| download | glibc-d6d062255489343810ad1e01d05f70acd9cd1918.tar glibc-d6d062255489343810ad1e01d05f70acd9cd1918.tar.gz glibc-d6d062255489343810ad1e01d05f70acd9cd1918.tar.bz2 glibc-d6d062255489343810ad1e01d05f70acd9cd1918.zip | |
elf/dl-lookup.c: Remove unnecessary static variable
undefined_msg is only used once contrary to the comment.
ChangeLog:
2014-06-23 Will Newton <will.newton@linaro.org>
* elf/dl-lookup.c (undefined_msg): Remove variable.
(_dl_lookup_symbol_x): Replace undefined_msg with string
literal.
| -rw-r--r-- | ChangeLog | 4 | ||||
| -rw-r--r-- | elf/dl-lookup.c | 5 |
2 files changed, 5 insertions, 4 deletions
@@ -1,5 +1,9 @@ 2014-06-23 Will Newton <will.newton@linaro.org> + * elf/dl-lookup.c (undefined_msg): Remove variable. + (_dl_lookup_symbol_x): Replace undefined_msg with string + literal. + * elf/dl-lookup.c (do_lookup_unique): New function. (do_lookup_x): Move STB_GNU_UNIQUE handling code to a separate function. diff --git a/elf/dl-lookup.c b/elf/dl-lookup.c index 896e1d2771..1c6ca8910c 100644 --- a/elf/dl-lookup.c +++ b/elf/dl-lookup.c @@ -39,9 +39,6 @@ #define VERSTAG(tag) (DT_NUM + DT_THISPROCNUM + DT_VERSIONTAGIDX (tag)) -/* We need this string more than once. */ -static const char undefined_msg[] = "undefined symbol: "; - struct sym_val { @@ -817,7 +814,7 @@ _dl_lookup_symbol_x (const char *undef_name, struct link_map *undef_map, /* XXX We cannot translate the message. */ _dl_signal_cerror (0, DSO_FILENAME (reference_name), N_("symbol lookup error"), - make_string (undefined_msg, undef_name, + make_string ("undefined symbol: ", undef_name, versionstr, versionname)); } *ref = NULL; |