aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2017-03-17 02:54:59 +0000
committerJoseph Myers <joseph@codesourcery.com>2017-03-17 02:54:59 +0000
commit0cb521871ba11772fb52617cdba1b66089ffd749 (patch)
tree63b2a9741e5f86eeea7580fb2b3c76c935eb34fe
parentd19887f8bb21481a95b9eff0b4efc909bfe82e2a (diff)
downloadglibc-0cb521871ba11772fb52617cdba1b66089ffd749.tar
glibc-0cb521871ba11772fb52617cdba1b66089ffd749.tar.gz
glibc-0cb521871ba11772fb52617cdba1b66089ffd749.tar.bz2
glibc-0cb521871ba11772fb52617cdba1b66089ffd749.zip
conformtest: Add mips XFAIL for struct stat st_dev type (bug 17786).
As noted in bug 17786, MIPS o32 struct stat has the wrong type of st_dev. This patch XFAILs that test in the conformtest expectations for this case (the test still fails after the patch because there's also a similar issue for st_rdev that needs reporting and XFAILing separately, and the bug should not be closed without an actual fix, not just XFAILing). Tested for mips with build-many-glibcs.py. [BZ #17786] * sysdeps/unix/sysv/linux/mips/mips32/Makefile: New file. * conform/data/sys/stat.h-data (stat.st_dev): XFAIL for mips-o32-linux.
-rw-r--r--ChangeLog5
-rw-r--r--conform/data/sys/stat.h-data3
-rw-r--r--sysdeps/unix/sysv/linux/mips/mips32/Makefile4
3 files changed, 11 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index 405b594dc3..517d6d356f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2017-03-17 Joseph Myers <joseph@codesourcery.com>
+ [BZ #17786]
+ * sysdeps/unix/sysv/linux/mips/mips32/Makefile: New file.
+ * conform/data/sys/stat.h-data (stat.st_dev): XFAIL for
+ mips-o32-linux.
+
[BZ #21260]
* sysdeps/unix/sysv/linux/alpha/Makefile
[$(subdir) = conform] (conformtest-xfail-conds): New variable.
diff --git a/conform/data/sys/stat.h-data b/conform/data/sys/stat.h-data
index f7a944adc5..79293bfe19 100644
--- a/conform/data/sys/stat.h-data
+++ b/conform/data/sys/stat.h-data
@@ -26,7 +26,8 @@ type time_t
type {struct stat}
-element {struct stat} dev_t st_dev
+// Bug 17786: st_dev has wrong type.
+xfail[mips-o32-linux]-element {struct stat} dev_t st_dev
element {struct stat} ino_t st_ino
element {struct stat} mode_t st_mode
element {struct stat} nlink_t st_nlink
diff --git a/sysdeps/unix/sysv/linux/mips/mips32/Makefile b/sysdeps/unix/sysv/linux/mips/mips32/Makefile
new file mode 100644
index 0000000000..0938f4097b
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/mips/mips32/Makefile
@@ -0,0 +1,4 @@
+ifeq ($(subdir),conform)
+# For bug 17786.
+conformtest-xfail-conds += mips-o32-linux
+endif