From 74e4489d4736d714e22cf5c3893f1b12243a5a45 Mon Sep 17 00:00:00 2001 From: Trumeet Date: Fri, 2 Apr 2021 14:11:41 -0700 Subject: feat(central): add logging to ProvisionRemoteServiceImpl There are no clients that handle the result of provisioning. If there is no logging, it would be hard to debug. --- .../yuuta/dn42peering/provision/ProvisionRemoteServiceImpl.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/central/src/main/java/moe/yuuta/dn42peering/provision/ProvisionRemoteServiceImpl.java b/central/src/main/java/moe/yuuta/dn42peering/provision/ProvisionRemoteServiceImpl.java index 3e432bd..a70385b 100644 --- a/central/src/main/java/moe/yuuta/dn42peering/provision/ProvisionRemoteServiceImpl.java +++ b/central/src/main/java/moe/yuuta/dn42peering/provision/ProvisionRemoteServiceImpl.java @@ -5,6 +5,8 @@ import io.vertx.core.AsyncResult; import io.vertx.core.Future; import io.vertx.core.Handler; import io.vertx.core.Vertx; +import io.vertx.core.impl.logging.Logger; +import io.vertx.core.impl.logging.LoggerFactory; import io.vertx.grpc.VertxChannelBuilder; import moe.yuuta.dn42peering.agent.proto.NodeConfig; import moe.yuuta.dn42peering.agent.proto.VertxAgentGrpc; @@ -18,6 +20,8 @@ import javax.annotation.Nonnull; import java.util.List; class ProvisionRemoteServiceImpl implements IProvisionRemoteService { + private final Logger logger = LoggerFactory.getLogger(getClass().getSimpleName()); + private final Vertx vertx; private final INodeService nodeService; private final IPeerService peerService; @@ -38,6 +42,7 @@ class ProvisionRemoteServiceImpl implements IProvisionRemoteService { @Override public IProvisionRemoteService deploy(long nodeId, @Nonnull Handler> handler) { + logger.info("Deploying to " + nodeId); vertx.sharedData().getLockWithTimeout("deploy_" + nodeId, 30 * 1000) .compose(lock -> { return Future.future(f -> nodeService.getNode((int)nodeId, f)) @@ -83,6 +88,8 @@ class ProvisionRemoteServiceImpl implements IProvisionRemoteService { return Future.succeededFuture(); }); }) + .onFailure(err -> logger.error("Cannot deploy to " + nodeId, err)) + .onSuccess(res -> logger.info("Deploy to " + nodeId + " succeed.")) .onComplete(handler); return this; } -- cgit v1.2.3